Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GeoTools to 24.2 #1683

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Upgrade GeoTools to 24.2 #1683

merged 3 commits into from
Feb 2, 2021

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jan 15, 2021 •
edited
Loading

@sbrunner sbrunner requested a review from danduk82 January 15, 2021 07:52
@sbrunner sbrunner changed the title Upgrade geotools to 23.4 Upgrade GeoTools to 23.4 Jan 15, 2021
@sbrunner sbrunner force-pushed the geotools branch 2 times, most recently from 8850e48 to 8828538 Compare January 21, 2021 10:58
@sbrunner sbrunner changed the title Upgrade GeoTools to 23.4 Upgrade GeoTools to 24.2 Jan 21, 2021
@sbrunner sbrunner requested a review from a user January 21, 2021 12:53
@mapfish mapfish deleted a comment from lgtm-com bot Jan 22, 2021
@sbrunner
Copy link
Member Author

After investigation, I found that we don't have anymore the following jar: javaee-api-7.0.jar
And I found tow different API of the following class:
https://docs.oracle.com/javaee/7/api/javax/servlet/ServletContext.html
https://tomcat.apache.org/tomcat-9.0-doc/servletapi/javax/servlet/ServletContext.html
Then I think that the changes are not bad...

ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbrunner sbrunner merged commit ce3a7cd into master Feb 2, 2021
@sbrunner sbrunner deleted the geotools branch February 2, 2021 14:19
@sbrunner sbrunner mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danduk82 danduk82 Awaiting requested review from danduk82

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbrunner